Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix classification model cuda move #1125

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

odulcy-mindee
Copy link
Collaborator

Related to #1039, closes #1020

@odulcy-mindee odulcy-mindee added type: bug Something isn't working module: models Related to doctr.models framework: pytorch Related to PyTorch backend labels Jan 9, 2023
@odulcy-mindee odulcy-mindee added this to the 0.7.0 milestone Jan 9, 2023
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odulcy-mindee thanks for the quick fix 😄

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1125 (f343747) into main (e66ce01) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   95.01%   94.98%   -0.03%     
==========================================
  Files         149      149              
  Lines        6417     6383      -34     
==========================================
- Hits         6097     6063      -34     
  Misses        320      320              
Flag Coverage Δ
unittests 94.98% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/classification/predictor/pytorch.py 94.73% <100.00%> (-0.27%) ⬇️
doctr/models/detection/predictor/pytorch.py 94.44% <0.00%> (-0.30%) ⬇️
doctr/models/predictor/base.py 81.81% <0.00%> (-0.28%) ⬇️
doctr/io/elements.py 92.07% <0.00%> (-0.27%) ⬇️
doctr/models/recognition/predictor/pytorch.py 90.90% <0.00%> (-0.27%) ⬇️
doctr/transforms/modules/tensorflow.py 83.42% <0.00%> (-0.10%) ⬇️
doctr/models/recognition/master/tensorflow.py 98.16% <0.00%> (-0.05%) ⬇️
doctr/models/recognition/master/pytorch.py 95.45% <0.00%> (-0.05%) ⬇️
doctr/models/recognition/vitstr/pytorch.py 97.43% <0.00%> (-0.04%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@odulcy-mindee odulcy-mindee merged commit 79e5736 into mindee:main Jan 9, 2023
@felixdittrich92 felixdittrich92 modified the milestones: 0.8.0, 0.7.0 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend module: models Related to doctr.models type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU inference error using db_resne50_rotation
2 participants